Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing options when using MultipartStore API #5695

Open
netthier opened this issue Apr 25, 2024 · 1 comment
Open

Allow passing options when using MultipartStore API #5695

netthier opened this issue Apr 25, 2024 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@netthier
Copy link
Contributor

netthier commented Apr 25, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I want to pass options as present in ObjectStore::put_multipart_opts to a multipart upload created via the MultipartStore interface.

Describe the solution you'd like

MultipartStore could receive a new method, maybe create_multipart_opts, taking something like PutMultipartOpts or an entirely new struct.

Annoyingly, it seems like AmazonS3 takes multipart options at creation, while MicrosoftAzure does so at completion...

Describe alternatives you've considered

Alternatively, the put_multipart API of ObjectStore could be used, but I need the ability to resume uploads after restarts, which seems to only be possible with the MultipartStore API which provides me with a MultipartId I can persist.

@netthier netthier added the enhancement Any new improvement worthy of a entry in the changelog label Apr 25, 2024
@tustvold
Copy link
Contributor

Annoyingly, it seems like AmazonS3 takes multipart options at creation, while MicrosoftAzure does so at completion...

Yup this is the thing that makes this hard 😅

I think adding resume support to put_multipart might be more tractable tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants