Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow presigning object_store multipart uploads #5694

Open
netthier opened this issue Apr 25, 2024 · 0 comments
Open

Allow presigning object_store multipart uploads #5694

netthier opened this issue Apr 25, 2024 · 0 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@netthier
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I want to be able to allow users to upload files to an object store using its multipart API without proxying the data through my server.

Describe the solution you'd like

Currently, signed URLs can be created through the Signer trait. It only has a single method which is highly generic across all request types. Not only does this mean that one cannot sign multipart requests, but it also means that one runs into problems such as #5691 for PUT requests.
If the Signer API were made more granular, like the ObjectStore API, e.g. with separate methods for signing get, put, multipart, etc. requests, this could be solved at the cost of more boilerplate.

Describe alternatives you've considered

I can't think of good alternatives that would also allow for multipart uploads.

@netthier netthier added the enhancement Any new improvement worthy of a entry in the changelog label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

1 participant