Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support list_with_offset for Azure using continuation token #5653

Open
alexwilcoxson-rel opened this issue Apr 16, 2024 · 1 comment
Open
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@alexwilcoxson-rel
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Azure object store implementation uses default list_with_offset implementation. It lists everything and does the filtering client side.

This is problematic for Delta Lake with large directories where we only really care about listing the latest files from a certain path.

Describe the solution you'd like
Microsoft pointed me to the Hadoop Azure filesystem listStatus API where startFrom is supported.

Basically the starting path is embedded in the opaque continuation token provided when the list API needs to page results. On the initial request this token is created and provided to the list API to start from the path.

The downside is that this is not documented. Perhaps this could be an opt-in option if there is hesitation using an undocumented format for the token that could break.

@alexwilcoxson-rel alexwilcoxson-rel added the enhancement Any new improvement worthy of a entry in the changelog label Apr 16, 2024
@tustvold
Copy link
Contributor

I think I would prefer to not implement undocumented shenanigans, that I presume would be hard to test 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants