Change UnionArray constructors
#5623
Open
+360
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
|
In light of #5368 I think I would like to sit on this for a bit, and we can look to get this bundled in when we next make a breaking release |
tustvold
approved these changes
May 8, 2024
|
I took the liberty of merging up main, making some minor tweaks to avoid hashmaps, and adding some additional tests. I think if you're happy this is then ready to go in (the next release is going to be breaking) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5613.
Rationale for this change
It came up in #5585 that the
UnionArrayconstructors are a bit odd when compared to the other array constructors.What changes are included in this PR?
UnionArray::try_newandUnionArray::new_uncheckedChanged arguments:
From:
field_type_ids: &[i8], type_ids: Buffer, value_offsets: Option<Buffer>, child_arrays: Vec<(Field, ArrayRef)>To:
fields: UnionFields, type_ids: ScalarBuffer<i8>, offsets: Option<ScalarBuffer<i32>>, children: Vec<ArrayRef>.The order of
childrenarrays must match the order of fields in theUnionFields.The validation in
try_newis a bit more strict.UnionBuilderIt now uses a
BTreeMapinstead of aHashMapinternally to get sorted iteration.Are there any user-facing changes?
This is a breaking change that changes the
UnionArrayconstructors.