Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup UnionArray Constructors #5613

Closed
tustvold opened this issue Apr 9, 2024 · 0 comments · Fixed by #5623
Closed

Cleanup UnionArray Constructors #5613

tustvold opened this issue Apr 9, 2024 · 0 comments · Fixed by #5623
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Apr 9, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The UnionArray constructors are somewhat at odds with the pattern followed for other array types.

Describe the solution you'd like

I would like the signature to be updated to be

fn try_new(fields: UnionFields, type_ids: ScalarBuffer<i8>, offsets: Option<ScalarBuffer<i32>>, children: Vec<ArrayRef>) 
    -> Result<Self, ArrowError>

into_parts should then be updated to match

Describe alternatives you've considered

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Apr 9, 2024
@tustvold tustvold self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant