Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[object-store] re-export hyper #5386

Open
ritchie46 opened this issue Feb 11, 2024 · 2 comments · May be fixed by #5389
Open

[object-store] re-export hyper #5386

ritchie46 opened this issue Feb 11, 2024 · 2 comments · May be fixed by #5389
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@ritchie46
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

To be able to better handle errors of object-store, we'd like to downcast errors to hyper errors. For this to be possible the version of hyper must match that one used by object-store.

Libraries can be dependent on different versions, so this is most robust and flexible with re-exporting hyper.
@ritchie46 ritchie46 added the enhancement Any new improvement worthy of a entry in the changelog label Feb 11, 2024
@tustvold
Copy link
Contributor

No objections from here, if we did ever move away from hyper we'd likely flag it as a breaking change

@ritchie46
Copy link
Contributor Author

Great. I shall make a PR.

@ritchie46 ritchie46 linked a pull request Feb 11, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: [object-store] re-export hyper ritchie46/arrow-rs
2 participants
@tustvold @ritchie46