Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison Kernels Ignore Nulls in Dictionary Values #4688

Closed
tustvold opened this issue Aug 11, 2023 · 2 comments · Fixed by #4691
Closed

Comparison Kernels Ignore Nulls in Dictionary Values #4688

tustvold opened this issue Aug 11, 2023 · 2 comments · Fixed by #4691
Assignees
Labels
arrow Changes to the arrow crate bug parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 11, 2023

Describe the bug

The dictionary comparison kernels fail to account for nulls nested within dictionaries

To Reproduce

fn test_dictionary_nested_nulls() {
    let keys = Int32Array::from(vec![0, 1, 2]);
    let v1 = Arc::new(Int32Array::from(vec![Some(0), None, Some(2)]));
    let a = DictionaryArray::new(keys.clone(), v1);
    let v2 = Arc::new(Int32Array::from(vec![None, Some(0), Some(2)]));
    let b = DictionaryArray::new(keys, v2);

    let r = eq_dyn(&a, &b).unwrap();
    assert_eq!(r.null_count(), 2);
}

Expected behavior

Additional context

@tustvold tustvold added the bug label Aug 11, 2023
@tustvold tustvold changed the title Comparison Kernels Ignore Dictionary Nulls Comparison Kernels Ignore Nulls in Dictionary Values Aug 11, 2023
@tustvold tustvold self-assigned this Aug 11, 2023
@tustvold tustvold added the parquet Changes to the parquet crate label Aug 15, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'parquet'} from #4691

@tustvold tustvold added the arrow Changes to the arrow crate label Aug 15, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #4691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant