Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace JSON Reader with RawReader #3610

Closed
tustvold opened this issue Jan 26, 2023 · 0 comments · Fixed by #4052
Closed

Replace JSON Reader with RawReader #3610

tustvold opened this issue Jan 26, 2023 · 0 comments · Fixed by #4052
Assignees
@tustvold
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

#3479 added a new JSON reader that is both faster and easier to maintain than the current implementation. However, as this represents a non-trivial breaking change, as the old reader exposes serde_json::Value, we need to give some time for downstream crates to migrate across.

The plan is to therefore spread this over 3 releases:

  1. A release with both Reader and RawReader
  2. A release with Reader deprecated
  3. A release with Reader removed

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jan 26, 2023
@alamb alamb added the arrow Changes to the arrow crate label Jan 26, 2023
@tustvold tustvold mentioned this issue Jan 30, 2023
Closed
@tustvold tustvold mentioned this issue Feb 12, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Feb 14, 2023
@tustvold
Deprecate old JSON reader (apache#3610)
d219f13
@tustvold tustvold mentioned this issue Feb 14, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Feb 14, 2023
@tustvold
Deprecate old JSON reader (apache#3610)
bbf0d5e
tustvold added a commit that referenced this issue Feb 22, 2023
@tustvold
Deprecate old JSON reader (#3610) (#3718)
6bf0aab
@tustvold tustvold mentioned this issue Mar 6, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 11, 2023
@tustvold
Remove old JSON Reader and Decoder (apache#3610)
e5497e7
@tustvold tustvold mentioned this issue Apr 11, 2023
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Apr 11, 2023
@tustvold
Remove old JSON Reader and Decoder (apache#3610)
068c95c
tustvold added a commit that referenced this issue Apr 12, 2023
@tustvold
Remove old JSON Reader and Decoder (#3610) (#4052)
6ce332a 
* Remove old JSON Reader and Decoder (#3610)

* More tests

* Fix doc

* Fix test

* Fix bench
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove old JSON Reader and Decoder (#3610) tustvold/arrow-rs
2 participants
@alamb @tustvold