Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Buffer::count_set_bits #3067

Closed
tustvold opened this issue Nov 9, 2022 · 2 comments · Fixed by #3071
Closed

Deprecate Buffer::count_set_bits #3067

tustvold opened this issue Nov 9, 2022 · 2 comments · Fixed by #3071
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Nov 9, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Buffer::count_set_bits is easy to incorrectly use, as Buffer does not know its accurate length in bits, only in bytes.

This led to #3061

Describe the solution you'd like

I would like to deprecate Buffer::count_set_bits in favour of Buffer::count_set_bits_offset which is less easy to accidentally misuse.

Describe alternatives you've considered

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Nov 9, 2022
@viirya
Copy link
Member

viirya commented Nov 9, 2022

Looks good to me. I think mostly we care about count_set_bits_offset, not count_set_bits.

tustvold added a commit to tustvold/arrow-rs that referenced this issue Nov 10, 2022
tustvold added a commit that referenced this issue Nov 10, 2022
* Deprecate Buffer::count_set_bits (#3067)

* Format
@alamb alamb added the arrow Changes to the arrow crate label Nov 11, 2022
@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'arrow'} from #3062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants