Update arrow-flight subcrates (#3044) #3052
Conversation
tustvold
force-pushed
the
arrow-flight-sub-crates
branch
from
f02d62c
to
ba7dea8
Compare
|
Marking as draft pending #3053 |
tustvold
force-pushed
the
arrow-flight-sub-crates
branch
from
f16f2af
to
21895c3
Compare
| - arrow-csv/** | ||
| - arrow-json/** |
There was a problem hiding this comment.
At the time arrow-flight had a transitive dependency on them via arrow
| @@ -122,18 +122,18 @@ pub trait ProstAnyExt { | |||
| /// | |||
| /// * `Ok(None)` when message type mismatch | |||
| /// * `Err` when parse failed | |||
| fn unpack<M: ProstMessageExt>(&self) -> ArrowResult<Option<M>>; | |||
| fn unpack<M: ProstMessageExt>(&self) -> Result<Option<M>, ArrowError>; | |||
There was a problem hiding this comment.
I saw you defined ArrowResult at arrow-flight/src/lib.rs, aren't we going to use it in arrow-flight crate?
There was a problem hiding this comment.
In general I've been trying to avoid aliasing Result, it was necessary in lib.rs due to name collisions
|
Benchmark runs are scheduled for baseline = 8d364fe and contender = 132152c. 132152c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #3044
Rationale for this change
Updates arrow-flight to depend only on sub crates
What changes are included in this PR?
Are there any user-facing changes?