Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CSV test data (#3044) #3051

Merged
merged 2 commits into from Nov 11, 2022
Merged

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Nov 8, 2022

Which issue does this PR close?

Part of #3044

Rationale for this change

In #3044 I originally didn't move the test data, following #3049 my thoughts on this have changed and I think it is better to keep these tests closer to the code they are tests for.

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the development-process Related to development process of arrow-rs label Nov 8, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 8, 2022
@tustvold tustvold marked this pull request as draft November 8, 2022 23:52
@tustvold
Copy link
Contributor Author

tustvold commented Nov 8, 2022

Needs test fix from #3049, marking as draft for now

@tustvold tustvold marked this pull request as ready for review November 9, 2022 05:13
@tustvold tustvold marked this pull request as draft November 9, 2022 10:00
@tustvold tustvold marked this pull request as ready for review November 10, 2022 04:02
@tustvold tustvold merged commit 02a3f5c into apache:master Nov 11, 2022
@ursabot
Copy link

ursabot commented Nov 11, 2022

Benchmark runs are scheduled for baseline = 0139682 and contender = 02a3f5c. 02a3f5c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants