Add BooleanArray::true_count and BooleanArray::false_count #2957
Conversation
tustvold
force-pushed
the
add-true-false-count
branch
from
1912d14
to
7dd649d
Compare
| @@ -103,6 +103,53 @@ impl BooleanArray { | |||
| &self.data.buffers()[0] | |||
| } | |||
|
|
|||
| /// Returns the number of true values within this buffer | |||
There was a problem hiding this comment.
| /// Returns the number of true values within this buffer | |
| /// Returns the number of non null, true values within this array |
|
|
||
| /// Returns the number of false values within this buffer | ||
| pub fn false_count(&self) -> usize { | ||
| match self.data.null_buffer() { |
There was a problem hiding this comment.
maybe this could be simplified into self.size() - self.null_count() - self.true_count() ? I think that would be basically as fast?
|
I filed #2963 to track this |
|
Benchmark runs are scheduled for baseline = 87ac05b and contender = 843a2e5. 843a2e5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2963
Rationale for this change
apache/datafusion#3989 (comment)
What changes are included in this PR?
Are there any user-facing changes?