Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup CI #2933

Merged
merged 5 commits into from Oct 27, 2022
Merged

Cleanup CI #2933

merged 5 commits into from Oct 27, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Oct 26, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

  • Consistently call clippy with -D warnings
  • Consistently use setup-builder action
  • Consistently test wasm32 as a separate job
  • Inline single-line run commands
  • Default rust-version in setup-builder
  • Add target option to setup-builder

Are there any user-facing changes?

No

@tustvold tustvold added the development-process Related to development process of arrow-rs label Oct 26, 2022
# "1" means line tables only, which is useful for panic tracebacks.
RUSTFLAGS: "-C debuginfo=1"
# https://github.com/rust-lang/cargo/issues/10280
CARGO_NET_GIT_FETCH_WITH_CLI: "true"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround for CircleCI that survived the import from to arrow-rs and can be removed

@tustvold tustvold marked this pull request as ready for review October 26, 2022 18:18
@alamb
Copy link
Contributor

alamb commented Oct 27, 2022

This PR appears to have conflicts in need of addressing

@tustvold
Copy link
Contributor Author

Fixed merge conflict, PTAL

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/actions/setup-builder/action.yaml Show resolved Hide resolved
cargo check -p parquet --no-default-features --features cli,snap,flate2,brotli --target wasm32-unknown-unknown
run: cargo check -p parquet --all-targets --no-default-features --features json

# test the parquet crate builds against wasm32 in stable rust
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a new check, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup - follow on to #2896

tustvold and others added 2 commits October 28, 2022 08:47
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@tustvold tustvold merged commit b4872b7 into apache:master Oct 27, 2022
@ursabot
Copy link

ursabot commented Oct 27, 2022

Benchmark runs are scheduled for baseline = 63417b1 and contender = b4872b7. b4872b7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants