Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freeze_with_dictionary API to MutableArrayData #2914

Closed
viirya opened this issue Oct 24, 2022 · 1 comment
Closed

Add freeze_with_dictionary API to MutableArrayData #2914

viirya opened this issue Oct 24, 2022 · 1 comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Oct 24, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We use MutableArrayData to copy array data for certain operation. One issue we faced is for DictionaryArray on which the dictionary array value is not extended from too. Because in our usage, arrays can be reused so we cannot rely on same dictionary value array (as it is possibly modified later). We can extend dictionary value array, but MutableArrayData lacks of an API to assign while freezing it.

Describe the solution you'd like

Add freeze_with_dictionary API to MutableArrayData.

Describe alternatives you've considered

Additional context

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Oct 24, 2022
@viirya viirya closed this as completed Oct 24, 2022
@alamb alamb added the arrow Changes to the arrow crate label Oct 28, 2022
@alamb
Copy link
Contributor

alamb commented Oct 28, 2022

label_issue.py automatically added labels {'arrow'} from #2915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants