Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Integration test JSON schema serialization #2876

Closed
alamb opened this issue Oct 14, 2022 · 1 comment · Fixed by #2868
Closed

Restore Integration test JSON schema serialization #2876

alamb opened this issue Oct 14, 2022 · 1 comment · Fixed by #2868
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented Oct 14, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
@maxburke noted:

it looks like from arrow 20 to 22 it was made conditional on the json feature, but it's now... gone?

@tustvold says

It was removed as it isn't meant as a stable serialization format

There is still serde::Serialize implemented for Schema if the corresponding feature is enabled but this isn't backwards compatible with the old serialization format

Describe the solution you'd like
I think publishing an arrow-integration-test crate containing the decoding logic for this format makes sense

Describe alternatives you've considered
Copy the code from git into new repos

Additional context
https://the-asf.slack.com/archives/C01QUFS30TD/p1665180205354589

@alamb alamb added arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog labels Oct 14, 2022
@alamb alamb closed this as completed Oct 14, 2022
@alamb alamb changed the title Integration test JSON schema serialization format was removed Restore Integration test JSON schema serialization Oct 14, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 17, 2022

Published on crates.io as https://crates.io/crates/arrow-integration-test/25.0.0 (though it has no readme for some reason 🤔 ) cc @maxburke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant