Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Primitive arity kernels to arrow-array #2787

Closed
tustvold opened this issue Sep 27, 2022 · 1 comment
Closed

Move Primitive arity kernels to arrow-array #2787

tustvold opened this issue Sep 27, 2022 · 1 comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

#2769 split out the arrays into a separate crate, in order to allow crates to depend on just arrow-array it is important to support basic operations on primitive arrays.

Parquet and IPC, need to perform a basic casts, e.g. Int32 -> Int64 or Date32 -> Date64. These could make use of the cast kernel but this supports a much wider range of types and conversions than is needed, and consequently has a significant dependency and codegen footprint.

Describe the solution you'd like

I would like to move the unary, try_unary, binary and try_binary kernels onto PrimitiveArray. The dyn and dictionary variants would remain in their current location for now.

Describe alternatives you've considered

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Sep 27, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Sep 27, 2022
tustvold added a commit that referenced this issue Sep 27, 2022
* Move primitive arity kernels (#2787)

* Fix doc
@alamb
Copy link
Contributor

alamb commented Oct 28, 2022

label_issue.py automatically added labels {'arrow'} from #2789

@alamb alamb added the arrow Changes to the arrow crate label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants