Better construction of RecordBatchOptions #2729
Conversation
askoa
changed the title
arrow/src/record_batch.rs
Outdated
| self.match_field_names = match_field_names; | ||
| self | ||
| } | ||
| pub fn row_count(mut self, row_count: usize) -> Self { |
There was a problem hiding this comment.
| pub fn row_count(mut self, row_count: usize) -> Self { | |
| pub fn row_count(mut self, row_count: Option<usize>) -> Self { |
I recommend having this parameter take an Option, otherwise there is no way to set it to None.
There was a problem hiding this comment.
The parameter is changed to Option
askoa
changed the title
|
https://github.com/apache/arrow-rs/actions/runs/3060939456/jobs/4940078478 was caused by So I have restarted the check and hopefully it will pass on a subsequent run |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
Docs failure is unrelated #2733 |
|
Benchmark runs are scheduled for baseline = 0ebd71e and contender = 43d912c. 43d912c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2728
What changes are included in this PR?
Removed the current option of initializing using
Defaultas the approach will work only within the crate.Defaultdoes not work outside the crate due to non-exhaustive option.Are there any user-facing changes?
Nope.