Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: bitwise operation #2718

Merged
merged 3 commits into from Sep 15, 2022
Merged

benchmark: bitwise operation #2718

merged 3 commits into from Sep 15, 2022

Conversation

liukun4515
Copy link
Contributor

@liukun4515 liukun4515 commented Sep 13, 2022 •
edited

Which issue does this PR close?

Closes #2714

waiting for #2716

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 13, 2022
@liukun4515 liukun4515 marked this pull request as ready for review September 15, 2022 14:45
@liukun4515 liukun4515 requested review from alamb and tustvold and removed request for alamb September 15, 2022 14:45
alamb
alamb approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @liukun4515

@alamb
Copy link
Contributor

alamb commented Sep 15, 2022

Docs failure is unrelated #2733

@alamb alamb merged commit eb9b456 into apache:master Sep 15, 2022
@ursabot
Copy link

ursabot commented Sep 15, 2022

Benchmark runs are scheduled for baseline = a7a9329 and contender = eb9b456. eb9b456 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@liukun4515 liukun4515 deleted the bitwise_benchmark_#2714 branch September 15, 2022 22:59
@liukun4515 liukun4515 mentioned this pull request Sep 15, 2022
Closed
6 tasks
@alamb alamb mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@tustvold tustvold Awaiting requested review from tustvold

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add benchmark for bitwise operation
3 participants
@liukun4515 @alamb @ursabot