Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support building comparator for dictionaries of primitive integer values #2672

Closed
viirya opened this issue Sep 7, 2022 · 0 comments · Fixed by #2673
Closed

Support building comparator for dictionaries of primitive integer values #2672

viirya opened this issue Sep 7, 2022 · 0 comments · Fixed by #2673
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Sep 7, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

build_compare doesn't support non-string (such as integer) dictionary arrays currently. As it is used by sorting kernel like lexsort, we cannot do sorting on such arrays for now. We should support these cases.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Sep 7, 2022
@viirya viirya mentioned this issue Sep 7, 2022
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support building comparator for dictionaries of primitive integer values viirya/arrow-rs
2 participants
@viirya @tustvold