Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow crate does not build with features = ["ffi"] and default_features = false. #2670

Closed
pacman82 opened this issue Sep 6, 2022 · 3 comments
Labels
arrow Changes to the arrow crate bug

Comments

@pacman82
Copy link

pacman82 commented Sep 6, 2022

Describe the bug

arrow crate does not build with features = ["ffi"] and default_features = false.

To Reproduce

inculde this in any Cargo.toml

[dependencies]
arrow = { version = "22.0.0", default-features = false, features = ["ffi"] }

yields error

error[E0432]: unresolved import `crate::array::layout`
   --> C:\Users\Markus\.cargo\registry\src\github.com-1ecc6299db9ec823\arrow-22.0.0\src\ffi.rs:125:20
    |
125 | use crate::array::{layout, ArrayData};
    |                    ^^^^^^ no `layout` in `array`

Expected behavior

I expected the build to work with only the ffi feature enabled. ffi should then imply all the other features it depends on.

Additional context

Build breaks due to missing layout in this use declaration:

use crate::array::{layout, ArrayData};

This broke the downstream build of arrow-odbc-py. Default features are enabled in build as a workaround.

@pacman82 pacman82 added the bug label Sep 6, 2022
@viirya
Copy link
Member

viirya commented Sep 6, 2022

This was duplicated to #2659 and was fixed.

@pacman82
Copy link
Author

pacman82 commented Sep 6, 2022

My bad, I did only browse the open issues to avoid duplication. Thanks!

@pacman82 pacman82 closed this as completed Sep 6, 2022
@viirya
Copy link
Member

viirya commented Sep 6, 2022

No worries. Thanks @pacman82 for reporting this.

@tustvold tustvold added the arrow Changes to the arrow crate label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

No branches or pull requests

3 participants