Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max/min string macro to generic helper function min_max_helper #2657

Closed
viirya opened this issue Sep 6, 2022 · 0 comments · Fixed by #2658
Closed

Change max/min string macro to generic helper function min_max_helper #2657

viirya opened this issue Sep 6, 2022 · 0 comments · Fixed by #2658
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Sep 6, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The max/min binary and string kernels use a macro min_max_binary_string and max/min primitive kernels use min_max_helper generic function. They can be combined to remove duplicate code.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Sep 6, 2022
@tustvold tustvold added the arrow Changes to the arrow crate label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants