Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lexsort LargeString Panics #2654

Closed
tustvold opened this issue Sep 5, 2022 · 5 comments · Fixed by #4687
Closed

Lexsort LargeString Panics #2654

tustvold opened this issue Sep 5, 2022 · 5 comments · Fixed by #4687
Assignees
@tustvold
Labels
bug

Comments

@tustvold
Copy link
Contributor

tustvold commented Sep 5, 2022

Describe the bug

Calling lexsort_to_indices on a LargeStringArray results in a panic

[Large]StringArray expects Datatype::[Large]Utf8

To Reproduce

Expected behavior

Additional context
@00Masato
Copy link
Contributor

00Masato commented Sep 6, 2022

Hi,
Can I try this issue?

@tustvold
Copy link
Contributor Author

tustvold commented Sep 6, 2022

Sure thing, let me know if you would like some further guidance 😄

@00Masato
Copy link
Contributor

00Masato commented Sep 7, 2022

@tustvold
Sorry,
May I have few more details? - e.g. code sample.

@tustvold
Copy link
Contributor Author

tustvold commented Sep 8, 2022

Hi @00Masato sorry for the delay. In light of #2687 and other issues related to this part of the codebase, I think the fix will probably be to just migrate away from DynComparator and so I'm not sure this is worth fixing. Apologies for the mixed messaging

@tustvold tustvold removed good first issue Good for newcomers help wanted labels Sep 8, 2022
@tustvold tustvold assigned tustvold and unassigned 00Masato Sep 8, 2022
@00Masato
Copy link
Contributor

00Masato commented Sep 8, 2022

OK!
Thank you for your response!

@jonmmease jonmmease mentioned this issue Mar 29, 2023
Closed
jonmmease added a commit to vega/vegafusion that referenced this issue Mar 30, 2023
@jonmmease
Work around LargeUtf8 sorting bug by casting to Utf8
8be9a9e 
apache/arrow-rs#2654
@jonmmease jonmmease mentioned this issue Mar 30, 2023
Merged
jonmmease added a commit to vega/vegafusion that referenced this issue Mar 30, 2023
@jonmmease
Work around LargeUtf8 to Utf8 comparison error (#288)
f832f4e 
* Work around LargeUtf8 sorting bug by casting to Utf8

apache/arrow-rs#2654

* Fix pre-transform arrow

* Add test for LargeUtf8 crash
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 11, 2023
@tustvold
Cleanup DynComparator (apache#2654)
33e30f0
@tustvold tustvold mentioned this issue Aug 11, 2023
Merged
tustvold added a commit that referenced this issue Aug 13, 2023
@tustvold
Cleanup DynComparator (#2654) (#4687)
ec273e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup DynComparator (#2654) tustvold/arrow-rs
2 participants
@tustvold @00Masato