Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly define overflow behavior for primitive arithmetic kernels #2641

Closed
viirya opened this issue Sep 3, 2022 · 0 comments · Fixed by #2643
Closed

Explicitly define overflow behavior for primitive arithmetic kernels #2641

viirya opened this issue Sep 3, 2022 · 0 comments · Fixed by #2643
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Sep 3, 2022 •
edited

Describe the bug

The primitive arithmetic kernels like add kernel don't define its behavior for overflow. We recently hit by this issue as overflow behavior is different between dev (panic on overflow) and release (overflow ignored). We should have explicit definition of overflow behavior for the kernels.

To Reproduce

Expected behavior

Additional context
@viirya viirya added the bug label Sep 3, 2022
This was referenced Sep 3, 2022
Closed
Merged
@viirya viirya changed the title Explicitly define overflow behavior for add kernel Explicitly define overflow behavior for primitive arithmetic kernels Sep 3, 2022
@tustvold tustvold added the arrow Changes to the arrow crate label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
2 participants
@viirya @tustvold