Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux, Mac and Windows .gitignore #2630

Merged
merged 1 commit into from Sep 2, 2022
Merged

Conversation

iajoiner
Copy link
Contributor

@iajoiner iajoiner commented Sep 2, 2022

Which issue does this PR close?

Closes #2629.

Rationale for this change

Some OS tends to generate files that shouldn't be tracked by git and I don't want to manually pick files I add to a commit.

What changes are included in this PR?

  1. CHANGELOG.md.bak as well as the standard .gitignore for Mac, Windows and Linux have been added to .gitignore.
    See https://github.com/github/gitignore/tree/main/Global for what have been added.

Are there any user-facing changes?

No.

@tustvold
Copy link
Contributor

tustvold commented Sep 2, 2022

I see no harm in this but FWIW you can setup a global gitignore on your system for this purpose. See core.excludesFile https://git-scm.com/docs/gitignore

@tustvold tustvold added the development-process Related to development process of arrow-rs label Sep 2, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iajoiner

.apdisk

# Linux .gitignore
*~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emacs!

@alamb alamb merged commit 2b2c15b into apache:master Sep 2, 2022
@ursabot
Copy link

ursabot commented Sep 2, 2022

Benchmark runs are scheduled for baseline = 5a49cfe and contender = 2b2c15b. 2b2c15b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@iajoiner iajoiner deleted the issue-2629 branch April 7, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CHANGELOG.md.bak and .DS_Store to .gitignore
5 participants