Cast timestamp array to string array with timezone #2608
Conversation
|
cc @sunchao |
viirya
force-pushed
the
fix_cast_timestamp_to_string
branch
from
6857794
to
1aac86a
Compare
viirya
force-pushed
the
fix_cast_timestamp_to_string
branch
from
1aac86a
to
9d1594a
Compare
|
cc @sunchao |
| @@ -28,33 +28,33 @@ use chrono::format::{parse, Parsed}; | |||
| use chrono::FixedOffset; | |||
|
|
|||
| macro_rules! extract_component_from_array { | |||
| ($array:ident, $builder:ident, $extract_fn:ident, $using:ident) => { | |||
| ($array:ident, $builder:ident, $extract_fn:ident, $using:ident, $convert:expr) => { | |||
There was a problem hiding this comment.
The result type of hour etc is Int32Array, but these APIs of Timelike (hour, minute, second etc) return u32. Previously in this macro, it is hardcoded as something like dt.$extract_fn() as i32. But for to_string API that is called for cast kernel, we don't need any conversion. In order to reuse this macro, I add this $convert to extract as i32 part.
|
Benchmark runs are scheduled for baseline = f9a3094 and contender = 12ad8d7. 12ad8d7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2607.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?