Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare dictionary with non-dictionary arrays in comparison kernels #2534

Closed
viirya opened this issue Aug 19, 2022 · 3 comments
Closed

Compare dictionary with non-dictionary arrays in comparison kernels #2534

viirya opened this issue Aug 19, 2022 · 3 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Aug 19, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Comparison kernels currently only support comparison among non-dictionary arrays and dictionary arrays separately. But in many use cases, we cannot prevent dictionary array to be compared with non-dictionary array. We should extend comparison kernels functionalities.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Aug 19, 2022
@tustvold
Copy link
Contributor

I think this is now complete?

@viirya
Copy link
Member Author

viirya commented Oct 18, 2022

Yea, I think so.

@viirya viirya closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants