Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up like_utf8_scalar for %pat% #2519

Closed
Dandandan opened this issue Aug 19, 2022 · 0 comments · Fixed by #2521
Closed

Speed up like_utf8_scalar for %pat% #2519

Dandandan opened this issue Aug 19, 2022 · 0 comments · Fixed by #2521
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@Dandandan
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently there is no special case for like patterns such as %pat%. We should add a special case that uses contains instead, which likely is faster than the regex parser.

Describe the solution you'd like

Describe alternatives you've considered

Check whether the like pattern only contains a pattern starting and ending with a wildcard, use contains for those instead.

Additional context

Make sure to run the benchmarks.

@Dandandan Dandandan added the enhancement Any new improvement worthy of a entry in the changelog label Aug 19, 2022
@alamb alamb added the arrow Changes to the arrow crate label Sep 1, 2022
@alamb alamb changed the title Speed up like_utf8_scalar for %pat% Speed up like_utf8_scalar for %pat% Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants