Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same codebase for boolean kernels #2507

Closed
viirya opened this issue Aug 18, 2022 · 0 comments · Fixed by #2508
Closed

Use same codebase for boolean kernels #2507

viirya opened this issue Aug 18, 2022 · 0 comments · Fixed by #2508
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Aug 18, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently and/or and and_kleene/or_kleene have different codebase (binary_boolean_kernel v.s. binary_boolean_kleene_kernel). It appears that they can share same code.

binary_boolean_kleene_kernel seems duplicating some logic in bitwise_bin_op_helper, and it looks very complicated.

It is better if we can make these boolean kernels use same utility functions.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Aug 18, 2022
@alamb alamb added the arrow Changes to the arrow crate label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants