Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byteorder dependency #2472

Closed
tustvold opened this issue Aug 16, 2022 · 0 comments · Fixed by #2486
Closed

Remove byteorder dependency #2472

tustvold opened this issue Aug 16, 2022 · 0 comments · Fixed by #2486
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Parquet currently depends on the byteorder crate, and only uses it in an extremely limited capacity.

Describe the solution you'd like

Much of the byteorder functionality can be found in the standard library, e.g. https://doc.rust-lang.org/std/primitive.u64.html#method.from_le_bytes. We should just use this instead and remove a dependency.

Describe alternatives you've considered

Additional context

@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog help wanted labels Aug 16, 2022
@alamb alamb added arrow Changes to the arrow crate parquet Changes to the parquet crate and removed arrow Changes to the arrow crate labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants