Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecimalArray Benchmarks #2388

Closed
tustvold opened this issue Aug 9, 2022 · 8 comments
Closed

DecimalArray Benchmarks #2388

tustvold opened this issue Aug 9, 2022 · 8 comments
Assignees
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 9, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We lack any benchmark coverage of DecimalArray and DecimalBuilder

Describe the solution you'd like

Some basic benchmarks of constructing, iterating and filtering decimal arrays

Describe alternatives you've considered

Additional context

Perhaps @liukun4515 you might want to pick this up in advance of making any changes?

@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog help wanted labels Aug 9, 2022
@alamb
Copy link
Contributor

alamb commented Aug 9, 2022

There are some benchmarks in #2360 -- see #2360 (comment) from @liukun4515

@liukun4515
Copy link
Contributor

pick up this issue. thanks @tustvold @alamb

@liukun4515 liukun4515 self-assigned this Aug 10, 2022
@liukun4515
Copy link
Contributor

liukun4515 commented Aug 10, 2022

we have many cases using the decimal data type, the benchmark and improvement for decimal are important for us.

@liukun4515
Copy link
Contributor

I have added the benchmark for validation decimalarray for decimal128 and decimal256 in #2360.

In the pr #2360, I doesn't refactor the validation of decimal128 because I got wired benchmark result.

After the pr merge, I will submit a new pr or issue to discuss this.
@alamb @tustvold

@liukun4515
Copy link
Contributor

liukun4515 commented Aug 11, 2022

writer benchmark for decimal

  • write decimal using primitive data type: int32, int64
  • write decimal using bytes data: byte_array, fixed_length_byte_array

@liukun4515
Copy link
Contributor

The performance of reading decimal data from bytes or fixed length bytes improves by #2528 #2522

@alamb
Copy link
Contributor

alamb commented Aug 31, 2022

🎉

@tustvold tustvold closed this as completed Nov 1, 2022
@tustvold
Copy link
Contributor Author

tustvold commented Nov 1, 2022

Closing as we have fairly good benchmark coverage now, and decimal array is now a primitive array yielding additional coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Development

No branches or pull requests

3 participants