Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncFileReaderNo Longer Object-Safe #2372

Closed
tustvold opened this issue Aug 8, 2022 · 0 comments
Closed

AsyncFileReaderNo Longer Object-Safe #2372

tustvold opened this issue Aug 8, 2022 · 0 comments
Labels
bug parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 8, 2022

Describe the bug

#2115 added a get_byte_ranges method, however, this included a where bound on Self. This has the effect of making the trait not object-safe - https://github.com/apache/arrow-datafusion/runs/7728204421?check_suite_focus=true.

Technically this is just a warning, which can be suppressed at the crate-level (anything lower doesn't have any effect), but this is not an ideal solution.

To Reproduce

apache/arrow-datafusion#3051

Expected behavior

AsyncFileReader should be object-safe

Additional context

@tustvold tustvold added the bug label Aug 8, 2022
@tustvold tustvold closed this as completed Aug 8, 2022
@alamb alamb added the parquet Changes to the parquet crate label Aug 10, 2022
@alamb alamb changed the title AsyncFileReader No Longer Object-Safe AsyncFileReaderNo Longer Object-Safe Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug parquet Changes to the parquet crate
Projects
None yet
Development

No branches or pull requests

2 participants