Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Object Store to using std::io::Error #2348

Closed
tustvold opened this issue Aug 7, 2022 · 1 comment
Closed

Move Object Store to using std::io::Error #2348

tustvold opened this issue Aug 7, 2022 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 7, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The ObjectStore crate currently makes use of Snafu to provide structured errors, these are then mapped to crate-level error type. This plumbing is confusing, verbose, adds limited additional utility, and leads to unnecessary breaking changes when adding new variants.

Describe the solution you'd like

The standard library has already developed an error abstraction for IO, namely std::io::Error. We should just use this

Describe alternatives you've considered

We could not do this

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Aug 7, 2022
@tustvold
Copy link
Contributor Author

Closing in favour of #2725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

1 participant