Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong logic in calculate_row_count when skipping values #2328

Closed
Ted-Jiang opened this issue Aug 5, 2022 · 0 comments · Fixed by #2329
Closed

Fix wrong logic in calculate_row_count when skipping values #2328

Ted-Jiang opened this issue Aug 5, 2022 · 0 comments · Fixed by #2329
Labels
parquet Changes to the parquet crate

Comments

@Ted-Jiang
Copy link
Member

Ted-Jiang commented Aug 5, 2022 •
edited

There are two kinds of erroe

one is parquet/src/arrow/arrow_reader.rs:1260

assert_eq!(a.data(), b.data(), "{:#?} vs {:#?}", a.data(), b.data());

Originally posted by @Ted-Jiang in #2315 (comment)
@Ted-Jiang Ted-Jiang changed the title Fix skip error calculate_row_count erroe Fix skip error calculate_row_count erro Aug 5, 2022
@Ted-Jiang Ted-Jiang changed the title Fix skip error calculate_row_count erro Fix skip error calculate_row_count error Aug 5, 2022
@Ted-Jiang Ted-Jiang mentioned this issue Aug 5, 2022
Merged
@Ted-Jiang Ted-Jiang changed the title Fix skip error calculate_row_count error Fix skip wrong logic in calculate_row_count Aug 5, 2022
@Ted-Jiang Ted-Jiang changed the title Fix skip wrong logic in calculate_row_count Fix wrong logic in calculate_row_count when skipping values Aug 5, 2022
@alamb alamb added the parquet Changes to the parquet crate label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix skip error in calculate_row_count. Ted-Jiang/arrow-rs
2 participants
@alamb @Ted-Jiang