Skip to content

Specialize FixedLenByteArrayReader for Parquet #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tustvold opened this issue Aug 4, 2022 · 1 comment · Fixed by #2528
Closed

Specialize FixedLenByteArrayReader for Parquet #2318

tustvold opened this issue Aug 4, 2022 · 1 comment · Fixed by #2528
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 4, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We have optimised implementations for reading most types directly to their arrow representations, however, we fallback to reading FixedLenByteArray and then using ComplexObjectArrayReader to cast it to the desired type.

This is problematic for a couple of reasons:

Describe the solution you'd like

I would like an optimized FixedLenByteArrayReader<const N: usize> that can be used to efficiently read values where the type is known up front, e.g. decimals and intervals. We can fallback to using FixedLenByteArray for the general case.

Describe alternatives you've considered

We could not do this

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Aug 4, 2022
@liukun4515
Copy link
Contributor

If your pr ready, feel free to at me and request me to review
@tustvold

tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 19, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 19, 2022
tustvold added a commit that referenced this issue Aug 20, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@alamb alamb added the parquet Changes to the parquet crate label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants