Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlightSqlService trait to pass session info along #2308

Closed
avantgardnerio opened this issue Aug 3, 2022 · 2 comments · Fixed by #2309
Closed

Update FlightSqlService trait to pass session info along #2308

avantgardnerio opened this issue Aug 3, 2022 · 2 comments · Fixed by #2309
Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@avantgardnerio
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Ballista requires keeping session state for things like what tables are registered. In order to look up this state, we need a key. According to the arrow docs, this key is in the request metadata. This metadata is not passed to the impls in the existing trait, so Ballista is not able to run any query more advanced than select 1;.

Describe the solution you'd like

Agree on a format to pass session data to implements.

Describe alternatives you've considered

  1. Passing raw tonic metadata
  2. handling all authentication in the base impl
  3. passing the 1 header info as a generic string
  4. decoding it and forcing it to be a UUID
  5. ...
@avantgardnerio avantgardnerio added the enhancement Any new improvement worthy of a entry in the changelog label Aug 3, 2022
@avantgardnerio
Copy link
Contributor Author

CC @andygrove and @alamb

@alamb
Copy link
Contributor

alamb commented Aug 3, 2022

so Ballista is not able to run any query more advanced than select 1;

LOL

@alamb alamb added the arrow-flight Changes to the arrow-flight crate label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants