Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize take_bits for non-null indices #2306

Closed
Dandandan opened this issue Aug 3, 2022 · 0 comments · Fixed by #2307
Closed

Optimize take_bits for non-null indices #2306

Dandandan opened this issue Aug 3, 2022 · 0 comments · Fixed by #2307
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@Dandandan
Copy link
Contributor

Dandandan commented Aug 3, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Take bits uses a normal iterator on the indices. This makes it slower, as it has to check each value on being non-null or not.

Describe the solution you'd like
We can write a fast path for non-nulls.

Describe alternatives you've considered
Not doing this.

Additional context

@Dandandan Dandandan added the enhancement Any new improvement worthy of a entry in the changelog label Aug 3, 2022
@Dandandan Dandandan changed the title Optimize take_bits for non nulls Optimize take_bits for non-null indices Aug 3, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 3, 2022
@alamb alamb changed the title Optimize take_bits for non-null indices Optimize take_bits for non-null indices Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants