Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonEqual for DictionaryArray Only Compares Keys #2294

Closed
tustvold opened this issue Aug 3, 2022 · 1 comment
Closed

JsonEqual for DictionaryArray Only Compares Keys #2294

tustvold opened this issue Aug 3, 2022 · 1 comment
Labels
arrow Changes to the arrow crate bug

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 3, 2022

Describe the bug

impl<T: ArrowPrimitiveType> JsonEqual for DictionaryArray<T> {
    fn equals_json(&self, json: &[&Value]) -> bool {
        // todo: this is wrong: we must test the values also
        self.keys().equals_json(json)
    }
}

To Reproduce

Expected behavior

Additional context

@tustvold tustvold added the bug label Aug 3, 2022
This was referenced Aug 3, 2022
@tustvold
Copy link
Contributor Author

JsonEqual was removed in #2296

@alamb alamb added the arrow Changes to the arrow crate label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

No branches or pull requests

2 participants