Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows / Mac and Coverage jobs are no longer running: arduino/setup-protoc@v1 is not allowed to be used in apache/arrow-rs #2279

Closed
tustvold opened this issue Aug 2, 2022 · 11 comments · Fixed by #2280
Assignees
Labels
bug development-process Related to development process of arrow-rs

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 2, 2022

Describe the bug

https://github.com/apache/arrow-rs/actions/runs/2781430582



Error: .github#L1arduino/setup-protoc@v1 is not allowed to be used in apache/arrow-rs. Actions in this workflow must be: within a repository owned by apache, created by GitHub, verified in the GitHub Marketplace, or matching the following: */*@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+, AdoptOpenJDK/install-jdk@*, JamesIves/github-pages-deploy-action@5dc1d5a192aeb5ab5b7d5a77b7d36aea4a7f5c92, TobKed/label-when-approved-action@*, actions-cool/issues-helper@*, actions-rs/*, al-cheb/configure-pagefile-action@*, amannn/action-semantic-pull-request@*, apache/*, burrunan/gradle-cache-action@*, bytedeco/javacpp-presets/.github/actions/*, chromaui/action@*, codecov/codecov-action@*, conda-incubator/setup-miniconda@*, container-tools/kind-action@*, container-tools/microshift-action@*, dawidd6/action-download-artifact@*, delaguardo/setup-graalvm@*, docker://jekyll/jekyll:*, docker://pandoc/core:2.9, eps1lon/actions-label-merge-conflict@*, gaurav-nelson/github-action-markdown-link-check@*, golang...
--
[Error: .github#L1](https://github.com/apache/arrow-rs/commit/ed9fc565f6b3bf0653ff342b523dbd1e2192d847#annotation_4184443006)
arduino/setup-protoc@v1 is not allowed to be used in apache/arrow-rs. Actions in this workflow must be: within a repository owned by apache, created by GitHub, verified in the GitHub Marketplace, or matching the following: */*@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+, AdoptOpenJDK/install-jdk@*, JamesIves/github-pages-deploy-action@5dc1d5a192aeb5ab5b7d5a77b7d36aea4a7f5c92, TobKed/label-when-approved-action@*, actions-cool/issues-helper@*, actions-rs/*, al-cheb/configure-pagefile-action@*, amannn/action-semantic-pull-request@*, apache/*, burrunan/gradle-cache-action@*, bytedeco/javacpp-presets/.github/actions/*, chromaui/action@*, codecov/codecov-action@*, conda-incubator/setup-miniconda@*, container-tools/kind-action@*, container-tools/microshift-action@*, dawidd6/action-download-artifact@*, delaguardo/setup-graalvm@*, docker://jekyll/jekyll:*, docker://pandoc/core:2.9, eps1lon/actions-label-merge-conflict@*, gaurav-nelson/github-action-markdown-link-check@*, golang...

This results in getting emails like this:

Screen Shot 2022-08-02 at 9 23 19 AM

To Reproduce

Expected behavior

Additional context

@tustvold tustvold added bug development-process Related to development process of arrow-rs labels Aug 2, 2022
@tustvold tustvold self-assigned this Aug 2, 2022
@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

I believe this came in via #2268 from @carols10cents

@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

I previously had to deal with the 'prost stopped bundling protoc' with linux -- and I added our own action https://github.com/apache/arrow-rs/tree/master/.github/actions/setup-builder to do so.

@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

In this case, since it is for the mac and windows job, I recommend either:

  1. Copy the contents of the setup-protoc action from arduino to this repository (which is ok under policy as then we control its contents)
  2. Stop testing arrow-flight on on mac and windows

For option 2 I was thinking we might be able to claim that the arrow-flight usecase is not sufficiently important to warrant figuring out the CI actions to run them

However, as I write this I realize that at least ensuring arrow-flight builds is important on mac and linux, and checking the build does require getting protoc running.

@tustvold I am happy to try and get this working, if you don't have the time

@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

I'll take a crack at this one

@alamb alamb changed the title arduino/setup-protoc@v1 is not allowed to be used in apache/arrow-rs Windows / Mac and Coverage jobs are no longer running: arduino/setup-protoc@v1 is not allowed to be used in apache/arrow-rs Aug 2, 2022
@alamb alamb assigned alamb and unassigned tustvold Aug 2, 2022
@tustvold
Copy link
Contributor Author

tustvold commented Aug 2, 2022

I think this is also stopping format jobs from running

@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

That is also likely . I am plodding along getting the windows builder running again. If I can't get it working in the next hour or two I'll get a PR up that at least fixes mac / formating

@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

I am very close 🤞

@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

PR to fix everything other than windows #2287

@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

I fixed fmt and mac jobs: #2287

I am still working on coverage and windows (I hate protoc)

@alamb
Copy link
Contributor

alamb commented Aug 2, 2022

In finally have a fix: #2280 😅 -- lots of putzing with windows

@carols10cents
Copy link
Contributor

Whoops! Sorry about that-- thank you for handling it @alamb 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants