Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Box Values in PrimitiveDictionaryBuilder #2215

Closed
tustvold opened this issue Jul 28, 2022 · 0 comments · Fixed by #2216
Closed

Don't Box Values in PrimitiveDictionaryBuilder #2215

tustvold opened this issue Jul 28, 2022 · 0 comments · Fixed by #2216
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

PrimitiveDictionaryBuilder constructs Box<u8> for its values, despite them being a known size. This appears to be a workaround for types such as f32 not implementing Hash or Eq

Describe the solution you'd like

Construct a newtype wrapper that implements Eq and Hash using ToByteSlice.

Describe alternatives you've considered

Additional context

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jul 28, 2022
@alamb alamb changed the title Don't Box Values in PrimitiveDictionaryBuilder Don't Box Values in PrimitiveDictionaryBuilder Aug 4, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants