Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GenericStringBuilder should use GenericBinaryBuilder #2156

Closed
HaoYang670 opened this issue Jul 25, 2022 · 1 comment · Fixed by #2181
Closed

The GenericStringBuilder should use GenericBinaryBuilder #2156

HaoYang670 opened this issue Jul 25, 2022 · 1 comment · Fixed by #2181
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, the string builder uses the list builder:

pub struct GenericStringBuilder<OffsetSize: OffsetSizeTrait> {
    builder: GenericListBuilder<OffsetSize, UInt8Builder>,
}

This requires another child array to be built, which leads to more memory overhead.

Describe the solution you'd like
I want the string builder to use the binary array.
Also I hope there would be some performance improvement in the bench_string. (At least, there should be no performance regression)

Describe alternatives you've considered
We could not do this if there is performance regression.

Additional context
Add any other context or screenshots about the feature request here.

@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Jul 25, 2022
@HaoYang670
Copy link
Contributor Author

I will work on it.

@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants