Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ArrayAccessor in Decimal128Iter and Decimal256Iter #2138

Closed
viirya opened this issue Jul 22, 2022 · 0 comments · Fixed by #2140
Closed

Use ArrayAccessor in Decimal128Iter and Decimal256Iter #2138

viirya opened this issue Jul 22, 2022 · 0 comments · Fixed by #2140
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Jul 22, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We have DecimalIter which iterates i128 values in Decimal128Array. One issue is that we should use Decimal128 which is formal value in Decimal128Array now. i128 is kept for back-compatibility purpose only. We should also follow other arrays to have iterators that leverage ArrayAccessor.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Jul 22, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
@alamb alamb changed the title Use ArrayAccessor in Decimal128Iter and Decimal256Iter Use ArrayAccessor in Decimal128Iter and Decimal256Iter Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants