Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicly export MapFieldNames #2118

Closed
alanhe opened this issue Jul 21, 2022 · 3 comments · Fixed by #2134
Closed

Publicly export MapFieldNames #2118

alanhe opened this issue Jul 21, 2022 · 3 comments · Fixed by #2134
Labels
arrow Changes to the arrow crate bug question Further information is requested

Comments

@alanhe
Copy link

alanhe commented Jul 21, 2022

Describe your question
arrow::array::MapBuilder is public (#1355), but MapFieldNames is not, making it impossible to call new() and with_capacity() with a proper value.

pub fn new(
field_names: Option<MapFieldNames>,
key_builder: K,
value_builder: V,
) -> Self {
let capacity = key_builder.len();
Self::with_capacity(field_names, key_builder, value_builder, capacity)
}

I guess MapFieldNames should be exported too, should it?

@alanhe alanhe added the question Further information is requested label Jul 21, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jul 22, 2022
@tustvold tustvold added the bug label Jul 22, 2022
@tustvold
Copy link
Contributor

This was an accidental bug introduced by #1879

@alamb
Copy link
Contributor

alamb commented Jul 22, 2022

@tustvold is this a regression in 19.0.0 (aka should I cut a new release candidate)?

@tustvold
Copy link
Contributor

I think it was a regression that landed in 17.0.0 and was only just noticed...

@alamb alamb added the arrow Changes to the arrow crate label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants