Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DecimalArray/DecimalBuilder to Decimal128Array/Decimal128Builder #2101

Closed
viirya opened this issue Jul 18, 2022 · 0 comments · Fixed by #2102
Closed

Rename DecimalArray/DecimalBuilder to Decimal128Array/Decimal128Builder #2101

viirya opened this issue Jul 18, 2022 · 0 comments · Fixed by #2102
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Jul 18, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

To be more clear on Decimal APIs and align with other Arrow implementations like C++, Python, we should rename DecimalArray/DecimalBuilder to Decimal128Array/Decimal128Builder.

Python: https://arrow.apache.org/docs/python/generated/pyarrow.Decimal128Array.html?highlight=decimal128array#pyarrow.Decimal128Array
C++: https://arrow.apache.org/docs/cpp/api/array.html?highlight=decimal128array#_CPPv4N5arrow15Decimal128ArrayE

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Jul 18, 2022
@alamb alamb added api-change Changes to the arrow API arrow Changes to the arrow crate labels Jul 21, 2022
@alamb alamb changed the title Rename DecimalArray/DecimalBuilder to Decimal128Array/Decimal128Builder Rename DecimalArray/DecimalBuilder to Decimal128Array/Decimal128Builder Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants