Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does serde_json specify the preserve_order feature in arrow package #2095

Closed
togami2864 opened this issue Jul 18, 2022 · 1 comment · Fixed by #2098
Closed

Why does serde_json specify the preserve_order feature in arrow package #2095

togami2864 opened this issue Jul 18, 2022 · 1 comment · Fixed by #2098
Labels
arrow Changes to the arrow crate question Further information is requested

Comments

@togami2864
Copy link

Which part is this question about
library

Describe your question
I want to know why is preseve_order specified in arrow.

serde_derive = { version = "1.0", default-features = false }

Because this feature turned on, our application using arrow wouldn't work well when getting the output of serialized JSON.
In my local env, all of the tests pass in this repository after removing the feature like this.

// Cargo.toml
serde = "1.0"
serde_derive = "1.0"
serde_json = "1.0"

Additional context

@togami2864 togami2864 added the question Further information is requested label Jul 18, 2022
@tustvold
Copy link
Contributor

@nevi-me 's comment #1882 (comment) would suggest this can likely be removed

tustvold added a commit to tustvold/arrow-rs that referenced this issue Jul 18, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jul 18, 2022
tustvold added a commit that referenced this issue Jul 18, 2022
* Remove preserve_order feature from serde_json (#2095)

* Fix tests
@alamb alamb changed the title Why does serde_json specify the preserve_order feature in arrow pacakge Why does serde_json specify the preserve_order feature in arrow package Jul 21, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants