Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make skip value in ByteArrayDecoderDictionary avoid decoding #2088

Closed
Ted-Jiang opened this issue Jul 16, 2022 · 1 comment · Fixed by #2154
Closed

Make skip value in ByteArrayDecoderDictionary avoid decoding #2088

Ted-Jiang opened this issue Jul 16, 2022 · 1 comment · Fixed by #2154
Labels
parquet Changes to the parquet crate

Comments

@Ted-Jiang
Copy link
Member

Possibly something for a follow up PR, but it would be nice if we could avoid decoding values only to dump them on the floor

Originally posted by @tustvold in #2076 (comment)
@Ted-Jiang Ted-Jiang mentioned this issue Jul 16, 2022
Merged
@tustvold
Copy link
Contributor

I think a lot of this has been implemented by @thinkharderdev in #2089 🎉

@thinkharderdev thinkharderdev mentioned this issue Jul 24, 2022
Merged
@alamb alamb added the parquet Changes to the parquet crate label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid decoding unneeded values in ByteArrayDecoderDictionary coralogix/arrow-rs
3 participants
@alamb @tustvold @Ted-Jiang