Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casting between timestamp types should use scalar multiply/divide kernels #2074

Closed
jhorstmann opened this issue Jul 15, 2022 · 1 comment
Closed

Casting between timestamp types should use scalar multiply/divide kernels #2074

jhorstmann opened this issue Jul 15, 2022 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@jhorstmann
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

See

arrow-rs/arrow/src/compute/kernels/cast.rs

Line 1045 in 86543a4

divide(

This creates a temporary array initialized with all same values. Instead it should use the scalar multiply/divide kernels for improved performance.
@jhorstmann jhorstmann added the enhancement Any new improvement worthy of a entry in the changelog label Jul 15, 2022
@waitingkuo waitingkuo mentioned this issue Aug 15, 2022
Closed
85 tasks
@tustvold
Copy link
Contributor

This was implemented in #2846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhorstmann @tustvold