Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of filter_dict #2062

Closed
viirya opened this issue Jul 14, 2022 · 0 comments · Fixed by #2063
Closed

Improve performance of filter_dict #2062

viirya opened this issue Jul 14, 2022 · 0 comments · Fixed by #2063
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog performance

Comments

@viirya
Copy link
Member

viirya commented Jul 14, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

When profiling a project using arrow-rs, found that filter_dict is among one of heavy stack trace:

arrow::compute::kernels::filter::filter_array::h7b1777b4117bb70a	
arrow::compute::kernels::filter::filter_dict::h72d7e1e318536f9f	
_$LT$arrow..array..array_dictionary..DictionaryArray$LT$T$GT$$u20$as$u20$core..convert..From$LT$arrow..array..data..ArrayData$GT$$GT$::from::h3716ed969de82ad7	
arrow::array::array::make_array::h48e79b04d13b81ef

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Jul 14, 2022
@alamb alamb changed the title Improve performance of filter_dict Improve performance of filter_dict Jul 21, 2022
@alamb alamb added arrow Changes to the arrow crate performance labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants