Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily materialize the null buffer builder of BooleanBuilder #2058

Closed
HaoYang670 opened this issue Jul 13, 2022 · 0 comments · Fixed by #2073
Closed

Lazily materialize the null buffer builder of BooleanBuilder #2058

HaoYang670 opened this issue Jul 13, 2022 · 0 comments · Fixed by #2073
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog performance

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Just as what we have done in the PrimitiveBuilder: https://github.com/apache/arrow-rs/blob/master/arrow/src/array/builder/primitive_builder.rs#L33-L35
We could put this optimization in the BooleanBuilder

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
I don't know why we only do this optimization for primitive builder. If there are some context or reasons, we could not do this.

Additional context
Found when reviewing #2056

@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Jul 13, 2022
@alamb alamb added arrow Changes to the arrow crate performance labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants