Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare DecimalArray::length as a constant #1967

Closed
HaoYang670 opened this issue Jun 30, 2022 · 0 comments · Fixed by #1968
Closed

Declare DecimalArray::length as a constant #1967

HaoYang670 opened this issue Jun 30, 2022 · 0 comments · Fixed by #1968
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
As for decimal 128 array, the value length is always 16 bytes, we should declare it as a constant.

Describe the solution you'd like
something like

impl DecimalArray {
    const VALUE_LEN: i32 = 16;
    ...
}

and remove the field DecimalArray::length

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Jun 30, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants