Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect n_buffers in FFI_ArrowArray #1959

Closed
viirya opened this issue Jun 29, 2022 · 0 comments · Fixed by #1960
Closed

Incorrect n_buffers in FFI_ArrowArray #1959

viirya opened this issue Jun 29, 2022 · 0 comments · Fixed by #1960
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Jun 29, 2022 •
edited

Describe the bug
We count n_buffers for FFI_ArrowArray by looking at ArrayData regarding with its null_buffer, and buffers. However, for NullType array, n_buffers should be 0. But currently n_buffers is 1.

n_buffers should be based on the layout spec.

We found this bug when transferring a NullType array between Rust and Java. The ffi ArrowArray fails a check at Arrow Java.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.
@viirya viirya added the bug label Jun 29, 2022
@viirya viirya mentioned this issue Jun 29, 2022
Merged
@alamb alamb changed the title Incorrect n_buffers in FFI_ArrowArray Incorrect n_buffers in FFI_ArrowArray Jul 7, 2022
@alamb alamb added the arrow Changes to the arrow crate label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calculate n_buffers in FFI_ArrowArray by data layout viirya/arrow-rs
2 participants
@viirya @alamb